Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixing multiclass logloss bug #529

Merged
merged 7 commits into from
Nov 25, 2016
Merged

Fixing multiclass logloss bug #529

merged 7 commits into from
Nov 25, 2016

Conversation

JackStat
Copy link
Contributor

fixes and test that closes #528

@topepo
Copy link
Owner

topepo commented Nov 18, 2016

Can you change the test to use a model that won't increase package dependencies (e.g. glm or kin)?

@JackStat
Copy link
Contributor Author

Any ideas on a good multiclass model to use?

@hadjipantelis
Copy link
Contributor

I would think that knn (which has no direct dependencies) should be a good choice. It is fast enough and minimises all dependencies. xTrain is just noise after all; no need to worry for good performance.

@coveralls
Copy link

coveralls commented Nov 18, 2016

Coverage Status

Coverage increased (+1.2%) to 16.018% when pulling dd4d146 on JackStat:master into 3f4e947 on topepo:master.

@coveralls
Copy link

coveralls commented Nov 25, 2016

Coverage Status

Coverage increased (+1.2%) to 16.018% when pulling 6afd32a on JackStat:master into 3f4e947 on topepo:master.

@JackStat
Copy link
Contributor Author

Probably not the best place to do this but I already had this pull req opened using my master branch. I just noticed that some of the link were broken in the train documentation so I updated them

@coveralls
Copy link

coveralls commented Nov 25, 2016

Coverage Status

Coverage increased (+1.2%) to 16.018% when pulling ada5efd on JackStat:master into 3f4e947 on topepo:master.

@topepo topepo merged commit 99bcdc0 into topepo:master Nov 25, 2016
@topepo
Copy link
Owner

topepo commented Nov 25, 2016

Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Crash in multiClassSummary.
4 participants