Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes to update_pkgs.R #558

Merged
merged 3 commits into from
Dec 28, 2016
Merged

Fixes to update_pkgs.R #558

merged 3 commits into from
Dec 28, 2016

Conversation

znmeb
Copy link
Contributor

@znmeb znmeb commented Dec 22, 2016 •
edited

  1. type = "both" doesn't work on Linux - see https://github.com/znmeb/caret/issues/1. I added some guards to the calls.
  2. The loop at the end to install missing packages wasn't finding a bunch of them. They're in BioConductor, so I changed the install.packages in the loop to biocLite.

Note also that the fresh variable is used before it's defined. I didn't fix that; I just set it to TRUE before sourcing the script.

@coveralls
Copy link

coveralls commented Dec 22, 2016 •
edited

Coverage Status

Coverage remained the same at 16.514% when pulling bca4cf0 on znmeb:master into 4b5f580 on topepo:master.

@topepo
Copy link
Owner

topepo commented Dec 28, 2016

Thanks

@topepo topepo closed this Dec 28, 2016
@topepo topepo reopened this Dec 28, 2016
@topepo topepo merged commit 4cfd1e3 into topepo:master Dec 28, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@znmeb @coveralls @topepo