Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

return full list of variables in xgb*$varImp #569

Merged
merged 1 commit into from
Jan 9, 2017
Merged

return full list of variables in xgb*$varImp #569

merged 1 commit into from
Jan 9, 2017

Conversation

ilia-kats
Copy link
Contributor

xgb.importance returns only features which are used at least once in the classifier. While usually not a problem, missing features in the importance data frame lead to an error in rfe when using caretFuncs with xgbTree as classifier. This patch adds the missing features to the importance output.

@coveralls
Copy link

coveralls commented Jan 9, 2017

Coverage Status

Coverage remained the same at 16.514% when pulling 91d7a83 on ilia-kats:xgb_varimp into 7fa510c on topepo:master.

@topepo topepo merged commit 854d128 into topepo:master Jan 9, 2017
@topepo
Copy link
Owner

topepo commented Jan 9, 2017

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants