Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add weights support to xgbTree model #614

Merged
merged 4 commits into from Mar 15, 2017

Conversation

schistyakov
Copy link
Contributor

According to xgboost documentation we can set items weights through the xgb.DMatrix. The default value for weights in caret::train is NULL, so the default behavior will stay the same

@coveralls
Copy link

coveralls commented Mar 9, 2017

Coverage Status

Coverage remained the same at 16.533% when pulling cd7abc2 on schistyakov:xgbTree-weights into 1553656 on topepo:master.

@topepo
Copy link
Owner

topepo commented Mar 13, 2017

Can you add some new test cases to the regression tests and also add a note in the news file?

@schistyakov
Copy link
Contributor Author

OK, will do it

@coveralls
Copy link

coveralls commented Mar 15, 2017

Coverage Status

Coverage increased (+2.01%) to 18.544% when pulling 71ff4f4 on schistyakov:xgbTree-weights into 1553656 on topepo:master.

@coveralls
Copy link

coveralls commented Mar 15, 2017

Coverage Status

Coverage increased (+2.01%) to 18.544% when pulling 71ff4f4 on schistyakov:xgbTree-weights into 1553656 on topepo:master.

@topepo topepo merged commit dd36518 into topepo:master Mar 15, 2017
@topepo
Copy link
Owner

topepo commented Mar 15, 2017

Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants