Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add feature flag for checking hosted domain #23

Conversation

matheuscscp
Copy link

@matheuscscp matheuscscp commented May 12, 2020

Description

Add a feature flag to toggle hosted domain check.

Motivation and Context

I have a deployment of Will.IAM where I tried to override the config oauth2.google.hostedDomains through the env. var passing the empty string so I could receive an empty string slice from Viper (empty list of hosted domains), but Viper or Golang thinks the env. var. is not set, instead of understanding it is set to the empty string, and fallbacks to the default config ({domain1, domain2} in the default config file config/local.yaml).

How Has This Been Tested?

Manually in my machine.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

  • My code has tests.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.

Release strategy

@matheuscscp matheuscscp force-pushed the feature/check-hosted-domain-flag branch from ae2e4d5 to 2c1e0e1 Compare May 12, 2020 21:09
@gerson-scanapieco gerson-scanapieco merged commit d2f0e1c into topfreegames:master May 12, 2020
@matheuscscp matheuscscp deleted the feature/check-hosted-domain-flag branch May 12, 2020 21:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants