Add feature flag for checking hosted domain #23
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add a feature flag to toggle hosted domain check.
Motivation and Context
I have a deployment of Will.IAM where I tried to override the config
oauth2.google.hostedDomains
through the env. var passing the empty string so I could receive an empty string slice from Viper (empty list of hosted domains), but Viper or Golang thinks the env. var. is not set, instead of understanding it is set to the empty string, and fallbacks to the default config ({domain1, domain2}
in the default config fileconfig/local.yaml
).How Has This Been Tested?
Manually in my machine.
Types of changes
Checklist:
Release strategy