Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add migrate to docker #26

Merged
merged 1 commit into from Dec 1, 2020
Merged

Add migrate to docker #26

merged 1 commit into from Dec 1, 2020

Conversation

joaobologna
Copy link
Collaborator

Description

Add both migration executable and .sql migration files to docker image.

Motivation and Context

With these changes, those who might want to execute migrations on other containers will be able to since all necessary files are available in the docker image.

How Has This Been Tested?

A docker image was built with the given changes, then executed - docker run <will-iam-image>. Once the service was available, I was able to run /postgres/migration on another docker container.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

  • My code has tests.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.

Release strategy

This PR is not a breaking change, it can be deployed at any time.

With these changes, those who might want to execute migrations on other containers will be able to since all necessary files are available in the docker image
@ghostec ghostec merged commit a9cff14 into topfreegames:master Dec 1, 2020
@joaobologna joaobologna deleted the feature/migrate-on-docker branch December 1, 2020 14:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants