Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Logging clan ownerID in leaveClan and transferOwnership operations (w… #36

Merged
merged 2 commits into from
Jul 31, 2019
Merged

Logging clan ownerID in leaveClan and transferOwnership operations (w… #36

merged 2 commits into from
Jul 31, 2019

Conversation

matheuscscp
Copy link
Contributor

…ill be reverted later)

cscatolini
cscatolini suggested changes Jul 31, 2019
View reviewed changes
Copy link
Contributor

@cscatolini cscatolini left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few remarks to be fixed, before we can merge this.

I'd also put a comment right above the func explaining that this will be reverted soon and is only for debugging a consistency issue.

api/clan.go
return
}
if clan == nil {
log.E(l, "Clan do not exists when logging clan ownerID.", func(cm log.CM) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

r/exists/exist

api/clan.go Outdated Show resolved Hide resolved
@coveralls
Copy link

coveralls commented Jul 31, 2019 •
edited
Loading

Coverage Status

Coverage increased (+0.1%) to 67.142% when pulling 22668a6 on matheuscscp:master into 9d99369 on topfreegames:master.

@cscatolini cscatolini merged commit 8b0513b into topfreegames:master Jul 31, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cscatolini cscatolini cscatolini approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@matheuscscp @coveralls @cscatolini