Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Returning pending applications and invites in retrieveClan route #46

Merged
merged 6 commits into from
Aug 22, 2019
Merged

Returning pending applications and invites in retrieveClan route #46

merged 6 commits into from
Aug 22, 2019

Conversation

matheuscscp
Copy link
Contributor

No description provided.

cscatolini
cscatolini reviewed Aug 22, 2019
View reviewed changes
Copy link
Contributor

@cscatolini cscatolini left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few comments. I still didn't take a look in the query itself.

models/clan.go Outdated Show resolved Hide resolved
api/clan.go Outdated Show resolved Hide resolved
models/clan.go Show resolved Hide resolved
@coveralls
Copy link

Coverage Status

Coverage increased (+0.2%) to 61.826% when pulling 2da34a8 on matheuscscp:feature/pending-apps-and-invites into 947d3cf on topfreegames:master.

cscatolini
cscatolini approved these changes Aug 22, 2019
View reviewed changes
Copy link
Contributor

@cscatolini cscatolini left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm approving it because we need this fix, but I expect another PR with api testing, specially if invalid parameters are sent.

@matheuscscp matheuscscp changed the title [WIP] Returning pending applications and invites in retrieveClan route Returning pending applications and invites in retrieveClan route Aug 22, 2019
@cscatolini cscatolini merged commit 52fde2b into topfreegames:master Aug 22, 2019
@matheuscscp matheuscscp deleted the feature/pending-apps-and-invites branch August 22, 2019 21:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cscatolini cscatolini cscatolini approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@matheuscscp @coveralls @cscatolini