Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add cache on GetGame function #50

Merged
merged 2 commits into from
Sep 4, 2019
Merged

Add cache on GetGame function #50

merged 2 commits into from
Sep 4, 2019

Conversation

capella
Copy link
Contributor

@capella capella commented Aug 28, 2019

Asking the games in high traffic routes wast a significative amount of time. This PR adds a cache of 1 minute in the GetGame function.

@coveralls
Copy link

coveralls commented Aug 28, 2019 •
edited
Loading

Coverage Status

Coverage increased (+0.04%) to 62.103% when pulling 907e95f on capella:games-with-cache into 28f1564 on topfreegames:master.

matheuscscp
matheuscscp reviewed Aug 28, 2019
View reviewed changes
Copy link
Contributor

@matheuscscp matheuscscp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice catch! Just a comment regarding cache TTL config, check it please!

api/app.go Outdated Show resolved Hide resolved
cscatolini
cscatolini approved these changes Sep 4, 2019
View reviewed changes
Copy link
Contributor

@cscatolini cscatolini left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@cscatolini cscatolini merged commit a76db73 into topfreegames:master Sep 4, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cscatolini cscatolini cscatolini approved these changes

@matheuscscp matheuscscp matheuscscp approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@capella @coveralls @cscatolini @matheuscscp