Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Random words #52

Merged
merged 4 commits into from
Sep 6, 2019
Merged

Random words #52

merged 4 commits into from
Sep 6, 2019

Conversation

capella
Copy link
Contributor

@capella capella commented Sep 2, 2019

I think about other ways to add these word list. Adding its in configs maps will exceed the maximum recommended ETCD config size (1mb). Creating a file with then and loading the content will add the overhead of initializing the read and creating a new env environment variable, also the final version of the docker image will include this file.

The idea of including the list as a config file and the list e got from here. I didn't include this lib directory, because it expected the running environment to have the /usr/share/dict/words file defined and this is not the case im alpine images.

@coveralls
Copy link

coveralls commented Sep 2, 2019

Coverage Status

Coverage decreased (-0.2%) to 62.054% when pulling 695a6ee on capella:random-word into f327e63 on topfreegames:master.

@capella
Copy link
Contributor Author

capella commented Sep 2, 2019

Does anyone know a better solution for adding a list of words to the program? I notice that the coverage change to 99% after this PR, I think I will need to change this because this hides the real coverage.

Copy link
Contributor

@matheuscscp matheuscscp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice job! Just one comment.

loadtest/helper.go Outdated Show resolved Hide resolved
@matheuscscp matheuscscp merged commit 8a182dd into topfreegames:master Sep 6, 2019
@matheuscscp matheuscscp changed the title Random word Random words Sep 6, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants