Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enable iOS simulator build #58

Merged
merged 7 commits into from
Oct 28, 2021
Merged

Enable iOS simulator build #58

merged 7 commits into from
Oct 28, 2021

Conversation

guilhermocc
Copy link
Contributor

@guilhermocc guilhermocc commented Oct 26, 2021 •
edited

Currently, it is not possible to run libpitaya unity project on ios simulated devices. Our build settings generate libpitaya (and dependencies) binaries just for arm64 and armv7, which are the CPU architectures used for iOS physical devices. However, the iOS simulator can run only on x86_64 or i386 architectures.

This PR aims to enable the build and execution of libpitaya on iOS simulators, including:

  • Generating new binaries for iOS x86_64 and i386 architectures.
  • Creating a new pre-build and post-build script needed for properly building the Xcode project without conflicts.
  • Adding a readme section with instructions for running the unity project on the simulated device.
  • Removing unused NSubstitute import from MainQueueDispatcher file that were breaking unity project build

New iOS binaries structure:
image

@guilhermocc guilhermocc marked this pull request as draft October 26, 2021 12:47
@guilhermocc guilhermocc self-assigned this Oct 26, 2021
@guilhermocc guilhermocc marked this pull request as ready for review October 26, 2021 14:42
@guilhermocc guilhermocc requested review from leohahn, felippeduran, henriqueoelze and henrod and removed request for leohahn October 26, 2021 14:42
henriqueoelze
henriqueoelze approved these changes Oct 27, 2021
View reviewed changes
Copy link
Contributor

@henriqueoelze henriqueoelze left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Besides the comment above, LGTM.

unity/PitayaExample/Assets/Pitaya/Editor/Pitaya.Editor.asmdef Outdated Show resolved Hide resolved
@guilhermocc guilhermocc merged commit 05c29ed into master Oct 28, 2021
@vitorbaraujo vitorbaraujo mentioned this pull request Feb 15, 2022
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@henriqueoelze henriqueoelze henriqueoelze approved these changes

@felippeduran felippeduran Awaiting requested review from felippeduran

@leohahn leohahn Awaiting requested review from leohahn

@henrod henrod Awaiting requested review from henrod

Assignees

@guilhermocc guilhermocc

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@guilhermocc @henriqueoelze