Skip to content

Commit

Permalink
Include fixes from comments.
Browse files Browse the repository at this point in the history
  • Loading branch information
Leonardo Hahn committed Jul 27, 2020
1 parent ae7b333 commit 4b4c389
Show file tree
Hide file tree
Showing 4 changed files with 5 additions and 6 deletions.
4 changes: 2 additions & 2 deletions api/scheduler_handler.go
Original file line number Diff line number Diff line change
Expand Up @@ -77,7 +77,7 @@ func (g *SchedulerCreateHandler) ServeHTTP(w http.ResponseWriter, r *http.Reques
timeoutSec,
)
if err != nil {
reporters.Report(reportersConstants.EventSchedulerCreate, map[string]interface{}{
_ = reporters.Report(reportersConstants.EventSchedulerCreate, map[string]interface{}{
"name": payload.Name,
"game": payload.Game,
"error": err,
Expand All @@ -92,7 +92,7 @@ func (g *SchedulerCreateHandler) ServeHTTP(w http.ResponseWriter, r *http.Reques
g.App.HandleError(w, status, "Create scheduler failed", err)
return
}
reporters.Report(reportersConstants.EventSchedulerCreate, map[string]interface{}{
_ = reporters.Report(reportersConstants.EventSchedulerCreate, map[string]interface{}{
"name": payload.Name,
"game": payload.Game,
})
Expand Down
1 change: 0 additions & 1 deletion controller/controller.go
Original file line number Diff line number Diff line change
Expand Up @@ -395,7 +395,6 @@ func ScaleUp(
return err
}
if existPendingPods {
// TODO(lhahn): Important.
return errors.New("there are pending pods, check if there are enough CPU and memory to allocate new rooms")
}

Expand Down
2 changes: 1 addition & 1 deletion metadata/version.go
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@
package metadata

//Version of Maestro
var Version = "9.5.3"
var Version = "9.5.4"

//KubeVersion is the desired Kubernetes version
var KubeVersion = "v1.13.9"
4 changes: 2 additions & 2 deletions models/game_room.go
Original file line number Diff line number Diff line change
Expand Up @@ -185,8 +185,8 @@ func createPod(
}

if err != nil {
// NOTE: We will get an error here if we cannot access redis. This implies that redis is probably not accessible,
// se we were not successful in adding the room's keys as well. That is why we don't call room.ClearAll here.
// NOTE: We will get an error here if we cannot access redis. It is therefore not necessary to call room.ClearAll here,
// since it is likely that Redis is off.
return nil, err
}

Expand Down

0 comments on commit 4b4c389

Please sign in to comment.