Feature/servers by metric #56
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
henrod
approved these changes
Dec 5, 2018
models/room.go
Outdated
|
|
||
| func getReadyRooms(tx redis.Pipeliner, schedulerName string, size int, mr *MixedMetricsReporter) ([]string, error) { | ||
| var result []string | ||
| rooms := tx.SScan( |
There was a problem hiding this comment.
Why SScan and not SRandMember?
There was a problem hiding this comment.
Great question! I didn't see there was a SRandMember command with count. I'll change it because it's better to return random members.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a route that returns a list of rooms ordered by a metric. For
legacyandroommetrics it returns at mostlimitavailable rooms. Forcpuandmemmetrics it returns at mostlimitrooms ordered by increasing cpu or memory usage.Also, I'm now reporting room usage metrics (cpu and memory) when a ping event is received if the corresponding metrics trigger is enabled.
Last but not least, I've fixed a bug that allowed a scheduler to be updated with metrics autoscaling bu no requests specified.
In a later PR we might change the cpu and memory autoscaler to retrieve the data we're now storing in Redis instead of calling Kubernetes API.