-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: configurable port ranges for each container port #624
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Codecov ReportAttention: Patch coverage is
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## main #624 +/- ##
==========================================
+ Coverage 64.30% 67.42% +3.12%
==========================================
Files 39 75 +36
Lines 2905 4857 +1952
==========================================
+ Hits 1868 3275 +1407
- Misses 909 1494 +585
+ Partials 128 88 -40 ☔ View full report in Codecov by Sentry. |
a99b6f0
to
0f55fc1
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Add some documentation about the changes in the Schedulers page, also add mentions about the validations and how it impact the game room creation.
Co-authored-by: João Bologna <31311651+joaobologna@users.noreply.github.com>
Co-authored-by: João Bologna <31311651+joaobologna@users.noreply.github.com>
…eegames/maestro into feat/container-port-ranges
2b48cb9
to
ec5992b
Compare
ec5992b
to
de0f04f
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Co-authored-by: Reinaldo Oliveira <reinaldo.oliveira@wildlifestudios.com>
No description provided.