Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: configurable port ranges for each container port #624

Merged
merged 13 commits into from
Jul 1, 2024

Conversation

gussf
Copy link
Collaborator

@gussf gussf commented Jun 14, 2024

No description provided.

Copy link
Collaborator

@hspedro hspedro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 85.41667% with 7 lines in your changes missing coverage. Please review.

Project coverage is 67.42%. Comparing base (bb118c8) to head (79587b6).
Report is 5 commits behind head on main.

Files Patch % Lines
...nternal/api/handlers/requestadapters/schedulers.go 80.76% 4 Missing and 1 partial ⚠️
internal/core/services/rooms/room_manager.go 89.47% 1 Missing and 1 partial ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #624      +/-   ##
==========================================
+ Coverage   64.30%   67.42%   +3.12%     
==========================================
  Files          39       75      +36     
  Lines        2905     4857    +1952     
==========================================
+ Hits         1868     3275    +1407     
- Misses        909     1494     +585     
+ Partials      128       88      -40     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@gussf gussf force-pushed the feat/container-port-ranges branch from a99b6f0 to 0f55fc1 Compare June 26, 2024 18:20
internal/api/handlers/requestadapters/schedulers.go Outdated Show resolved Hide resolved
internal/api/handlers/requestadapters/schedulers.go Outdated Show resolved Hide resolved
internal/core/entities/game_room/container.go Outdated Show resolved Hide resolved
proto/api/v1/messages.proto Outdated Show resolved Hide resolved
internal/core/entities/scheduler.go Outdated Show resolved Hide resolved
internal/core/entities/scheduler.go Outdated Show resolved Hide resolved
Copy link
Collaborator

@reinaldooli reinaldooli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add some documentation about the changes in the Schedulers page, also add mentions about the validations and how it impact the game room creation.

gussf and others added 4 commits June 27, 2024 14:18
Co-authored-by: João Bologna <31311651+joaobologna@users.noreply.github.com>
Co-authored-by: João Bologna <31311651+joaobologna@users.noreply.github.com>
@gussf gussf force-pushed the feat/container-port-ranges branch 2 times, most recently from 2b48cb9 to ec5992b Compare July 1, 2024 16:16
@gussf gussf force-pushed the feat/container-port-ranges branch from ec5992b to de0f04f Compare July 1, 2024 16:17
Copy link
Collaborator

@joaobologna joaobologna left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Co-authored-by: Reinaldo Oliveira <reinaldo.oliveira@wildlifestudios.com>
@gussf gussf merged commit 5f7fd7d into main Jul 1, 2024
6 checks passed
@gussf gussf deleted the feat/container-port-ranges branch July 1, 2024 17:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants