Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rollback on ErrImageNeverPull, ErrImagePullBackOff and CrashLoopBackOff #70

Merged
merged 2 commits into from
Aug 15, 2019

Conversation

lftakakura
Copy link
Contributor

No description provided.

@coveralls
Copy link

coveralls commented Aug 15, 2019

Coverage Status

Coverage decreased (-0.2%) to 81.121% when pulling 9f109c0 on feature/rollback-pod-with-errors into 6780438 on master.

Copy link
Contributor

@andrehp andrehp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job! This is going to be very useful!

I just left some small comments

@@ -8,7 +8,7 @@
package metadata

//Version of Maestro
var Version = "8.1.1"
var Version = "8.2.1"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why not 8.2.0?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

8.2.0 was released already. Forgot to change the metadata =P

models/constants.go Show resolved Hide resolved
@lftakakura lftakakura merged commit 1d40908 into master Aug 15, 2019
lftakakura added a commit that referenced this pull request Oct 11, 2019
…ff (#70)

* Rollback on ErrImageNeverPull, ErrImagePullBackOff and CrashLoopBackOff

* Add ErrInvalidImageName
lftakakura added a commit that referenced this pull request Oct 15, 2019
…ff (#70)

* Rollback on ErrImageNeverPull, ErrImagePullBackOff and CrashLoopBackOff

* Add ErrInvalidImageName
lftakakura added a commit that referenced this pull request Oct 15, 2019
…ff (#70)

* Rollback on ErrImageNeverPull, ErrImagePullBackOff and CrashLoopBackOff

* Add ErrInvalidImageName
@caiordjesus caiordjesus deleted the feature/rollback-pod-with-errors branch February 14, 2022 18:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants