Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix OpManager progress tracking #71

Merged
merged 3 commits into from
Aug 16, 2019
Merged

Fix OpManager progress tracking #71

merged 3 commits into from
Aug 16, 2019

Conversation

lftakakura
Copy link
Contributor

With the recent changes, the progress status broke

@coveralls
Copy link

coveralls commented Aug 15, 2019 •
edited
Loading

Coverage Status

Coverage increased (+0.03%) to 81.148% when pulling 8116b89 on fix/operation-progress into 1d40908 on master.

andrehp
andrehp reviewed Aug 15, 2019
View reviewed changes
models/scheduler.go Outdated Show resolved Hide resolved
cscatolini
cscatolini approved these changes Aug 16, 2019
View reviewed changes
Copy link
Contributor

@cscatolini cscatolini left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Nice job using constants instead of strings spread all over the place!

I'd just add a comment explaining this if:

if status["description"] != models.OpManagerFinished && new/total > 0.99 {

Feel free to merge once this is done.

@lftakakura lftakakura merged commit 4245dfa into master Aug 16, 2019
lftakakura added a commit that referenced this pull request Oct 11, 2019
@lftakakura
Fix OpManager progress tracking (#71)
804e75d 
* Fix OpManager progress tracking

* Remove unnecessary scheduler method

* Add comment to confusing line of code in getOperationRollingProgress function
lftakakura added a commit that referenced this pull request Oct 15, 2019
@lftakakura
Fix OpManager progress tracking (#71)
f8cf2bc 
* Fix OpManager progress tracking

* Remove unnecessary scheduler method

* Add comment to confusing line of code in getOperationRollingProgress function
lftakakura added a commit that referenced this pull request Oct 15, 2019
@lftakakura
Fix OpManager progress tracking (#71)
9826ce5 
* Fix OpManager progress tracking

* Remove unnecessary scheduler method

* Add comment to confusing line of code in getOperationRollingProgress function
@caiordjesus caiordjesus deleted the fix/operation-progress branch February 14, 2022 18:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cscatolini cscatolini cscatolini approved these changes

@ghostec ghostec Awaiting requested review from ghostec

@henrod henrod Awaiting requested review from henrod

@andrehp andrehp Awaiting requested review from andrehp

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@lftakakura @coveralls @cscatolini @andrehp