Fix maestro tests #91
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
victor-carvalho
changed the base branch from
master
to
refactor/rolling-update-progress
lftakakura
reviewed
Jun 22, 2020
api/room_handler_test.go
Outdated
| }, | ||
| }, gomock.Any()) | ||
| }, gomock.Any()).AnyTimes() |
There was a problem hiding this comment.
It is not ideal to use AnyTimes. If possible assert that HGet is called the exact number of times it should
There was a problem hiding this comment.
Yeah, it's not needed here. It's only called one time
| @@ -1361,23 +1367,25 @@ cmd: | |||
| }) | |||
|
|
|||
| Describe("ScaleUp", func() { | |||
| BeforeEach(func() { | |||
| config.Set("watcher.maxScaleUpAmount", 100) | |||
There was a problem hiding this comment.
Don't we need to unset this value after?
There was a problem hiding this comment.
Sure, I will change this. I thought config was being reset every test but it was because I was running only one test separately.
gabrielcorado
approved these changes
Jun 22, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This branch fixes all tests from branch https://github.com/topfreegames/maestro/tree/refactor/rolling-update-progress