-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add flag on mqtt history endpoint #20
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thiagomachado
approved these changes
Apr 13, 2022
danielbdias
suggested changes
Apr 13, 2022
danielbdias
suggested changes
Apr 13, 2022
danielbdias
suggested changes
Apr 13, 2022
danielbdias
approved these changes
Apr 13, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Given the needed of retrieving blocked messages from MQTT History: on this MR we are we adding a flag on its endpoint to introduce a better experience for those who will receive these messages.
How to test it
Pre-requisites
make deps setup/mongo
;make run
.Test cases
Retrieving messages from games that have
isBlocked:false
curl --location --request GET 'http://localhost:8888/history/chat/mygame/room/general?userid=mygame:metagame-mygame&limit=1000&isBlocked=false'
# you should see an array with one message from Bob
Retrieving messages from games that have
isBlocked:true
curl --location --request GET 'http://localhost:8888/history/chat/myanothergame/room/general?userid=myanothergame:metagame-myanothergame&limit=1000'
# you should see an array with one message from Alice
--
*PS Although we have included
isBlocked=false
in our endpoint, this value is already configured as default.