Fixes and defaults from Config

api/app.go

@@ -44,6 +44,13 @@ type App struct {
 	Server            *http.Server
 	Cache             *cache.Cache
 	OffersCacheMaxAge time.Duration
+	Pagination        *Pagination
+}
+
+//Pagination holds the page size (limit) and the offset that is the page number
+type Pagination struct {
+	Limit  uint64
+	Offset uint64
 }
 
 //NewApp ctor
@@ -214,11 +221,21 @@ func (a *App) configureApp() error {
 	a.configureSentry()
 
 	a.MaxAge = a.Config.GetInt64("cache.maxAgeSeconds")
+	a.configurePagination()
 	a.configureServer()
 	a.configureCache()
 	return nil
 }
 
+func (a *App) configurePagination() {
+	limit := uint64(a.Config.GetInt64("pagination.limit"))
+	offset := uint64(a.Config.GetInt64("pagination.offset"))
+	a.Pagination = &Pagination{
+		Limit:  limit,
+		Offset: offset,
+	}
+}
+
 func (a *App) configureCache() {
 	maxAge := time.Duration(a.Config.GetInt64("offersCache.maxAgeSeconds")) * time.Second
 	cleanupInterval := time.Duration(a.Config.GetInt64("offersCache.cleanupInterval")) * time.Second

api/offer.go

@@ -185,20 +185,27 @@ func (g *OfferHandler) list(w http.ResponseWriter, r *http.Request) {
 
 	var limit uint64
 	if limitStr == "" {
-		limit = 50
-	} else if limit, err = strconv.ParseUint(limitStr, 10, 64); err != nil {
-		logger.WithError(err).Error("List game offers failed.")
-		g.App.HandleError(w, http.StatusBadRequest, "The limit parameter must be an uint.", err)
-		return
+		limit = g.App.Pagination.Limit
+	} else {
+		var err error
+		limit, err = strconv.ParseUint(limitStr, 10, 64)
+		if err != nil {
+			logger.WithError(err).Error("List game offers failed.")
+			g.App.HandleError(w, http.StatusBadRequest, "The limit parameter must be an uint.", err)
+			return
+		}
 	}
 
 	var offset uint64
 	if offsetStr == "" {
-		offset = 0
-	} else if offset, err = strconv.ParseUint(offsetStr, 10, 64); err != nil {
-		logger.WithError(err).Error("List game offers failed.")
-		g.App.HandleError(w, http.StatusBadRequest, "The offset parameter must be an uint.", err)
-		return
+		offset = g.App.Pagination.Offset
+	} else {
+		offset, err = strconv.ParseUint(offsetStr, 10, 64)
+		if err != nil {
+			logger.WithError(err).Error("List game offers failed.")
+			g.App.HandleError(w, http.StatusBadRequest, "The offset parameter must be an uint.", err)
+			return
+		}
 	}
 
 	var offers []*models.Offer
@@ -221,10 +228,5 @@ func (g *OfferHandler) list(w http.ResponseWriter, r *http.Request) {
 	}
 
 	bts, _ := json.Marshal(responseObj)
-	status := http.StatusOK
-	if len(offers) == 0 {
-		status = http.StatusNoContent
-	}
-
-	WriteBytes(w, status, bts)
+	WriteBytes(w, http.StatusOK, bts)
 }

api/offer_test.go

@@ -1099,7 +1099,7 @@ var _ = Describe("Offer Template Handler", func() {
 			app.Router.ServeHTTP(recorder, request)
 			Expect(recorder.Header().Get("Content-Type")).To(Equal("application/json"))
 
-			Expect(recorder.Code).To(Equal(http.StatusNoContent))
+			Expect(recorder.Code).To(Equal(http.StatusOK))
 			var obj map[string]interface{}
 			err := json.Unmarshal(recorder.Body.Bytes(), &obj)
 			Expect(err).NotTo(HaveOccurred())
@@ -1224,7 +1224,7 @@ var _ = Describe("Offer Template Handler", func() {
 
 			app.Router.ServeHTTP(recorder, request)
 			Expect(recorder.Header().Get("Content-Type")).To(Equal("application/json"))
-			Expect(recorder.Code).To(Equal(http.StatusNoContent))
+			Expect(recorder.Code).To(Equal(http.StatusOK))
 
 			var obj map[string]interface{}
 			err := json.Unmarshal(recorder.Body.Bytes(), &obj)

config/local.yaml

@@ -23,3 +23,6 @@ offersCache:
 basicauth:
   username: user
   password: pass
+pagination:
+  limit: 50
+  offset: 0

config/test.yaml

@@ -20,3 +20,6 @@ cache:
 offersCache:
   maxAgeSeconds: 300
   cleanupInterval: 30
+pagination:
+  limit: 50
+  offset: 0