Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Avoid creating two spans for nats rpc server #103

Merged
merged 1 commit into from Jun 1, 2019
Merged

Avoid creating two spans for nats rpc server #103

merged 1 commit into from Jun 1, 2019

Conversation

andrehp
Copy link
Contributor

@andrehp andrehp commented May 29, 2019

The nats RPC server was creating a tracing span which was not being closed or used

@andrehp andrehp requested a review from cscatolini May 29, 2019 19:56
@coveralls
Copy link

Pull Request Test Coverage Report for Build 900

  • 1 of 14 (7.14%) changed or added relevant lines in 3 files are covered.
  • 2 unchanged lines in 1 file lost coverage.
  • Overall coverage decreased (-0.06%) to 68.827%
Changes Missing Coverage Covered Lines Changed/Added Lines %
service/remote.go 0 1 0.0%
util/util.go 0 12 0.0%
Files with Coverage Reduction New Missed Lines %
agent/agent.go 2 80.9%
Totals Coverage Status
Change from base Build 897: -0.06%
Covered Lines: 4407
Relevant Lines: 6403
💛 - Coveralls

cscatolini
cscatolini approved these changes Jun 1, 2019
View reviewed changes
Copy link
Contributor

@cscatolini cscatolini left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice catch!

@cscatolini cscatolini merged commit dda6bd5 into master Jun 1, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cscatolini cscatolini cscatolini approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@andrehp @coveralls @cscatolini