Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Properly closing grpc connections on deregister #104

Merged
merged 3 commits into from Jun 20, 2019

Conversation

Projects
None yet
4 participants
@andrehp
Copy link
Contributor

commented Jun 18, 2019

The gRPC RPC client is currently leaking connections because they are not being properly closed.

References:
grpc/grpc-go#2086
https://godoc.org/google.golang.org/grpc#ClientConn.NewStream

@andrehp andrehp requested a review from Henrod Jun 18, 2019

@coveralls

This comment has been minimized.

Copy link

commented Jun 18, 2019

Pull Request Test Coverage Report for Build 912

  • 27 of 38 (71.05%) changed or added relevant lines in 1 file are covered.
  • 2 unchanged lines in 1 file lost coverage.
  • Overall coverage increased (+0.004%) to 68.767%

Changes Missing Coverage Covered Lines Changed/Added Lines %
cluster/grpc_rpc_client.go 27 38 71.05%
Files with Coverage Reduction New Missed Lines %
cluster/grpc_rpc_client.go 2 75.96%
Totals Coverage Status
Change from base Build 907: 0.004%
Covered Lines: 4410
Relevant Lines: 6413

💛 - Coveralls

@andrehp andrehp requested a review from felipejfc Jun 18, 2019

Show resolved Hide resolved cluster/grpc_rpc_client.go Outdated
Show resolved Hide resolved cluster/grpc_rpc_client.go Outdated
@Henrod

Henrod approved these changes Jun 19, 2019

@andrehp andrehp merged commit d059578 into master Jun 20, 2019

3 of 4 checks passed

continuous-integration/travis-ci/pr The Travis CI build failed
Details
GolangCI No issues found!
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
coverage/coveralls First build on fix/grpc_leak at 68.642%
Details

@andrehp andrehp deleted the fix/grpc_leak branch Jun 20, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.