Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lazy gRPC connections #109

Merged
merged 4 commits into from
Sep 6, 2019
Merged

Lazy gRPC connections #109

merged 4 commits into from
Sep 6, 2019

Conversation

andrehp
Copy link
Contributor

@andrehp andrehp commented Sep 5, 2019

No description provided.

@andrehp andrehp force-pushed the feature/lazy_grpc_connections branch from 2a5a248 to c51b175 Compare September 5, 2019 21:40
@coveralls
Copy link

coveralls commented Sep 5, 2019

Pull Request Test Coverage Report for Build 933

  • 42 of 54 (77.78%) changed or added relevant lines in 2 files are covered.
  • 2 unchanged lines in 1 file lost coverage.
  • Overall coverage increased (+0.07%) to 68.721%

Changes Missing Coverage Covered Lines Changed/Added Lines %
cluster/grpc_rpc_client.go 41 53 77.36%
Files with Coverage Reduction New Missed Lines %
agent/agent.go 2 81.4%
Totals Coverage Status
Change from base Build 925: 0.07%
Covered Lines: 4427
Relevant Lines: 6442

💛 - Coveralls

Copy link
Contributor

@cscatolini cscatolini left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Amazing job @andrehp !
I have a small comment about the log messages, but it is not a blocker.

cluster/grpc_rpc_client.go Show resolved Hide resolved
@andrehp andrehp merged commit c2f787d into master Sep 6, 2019
@andrehp andrehp deleted the feature/lazy_grpc_connections branch September 6, 2019 20:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants