Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

log heartbeat if true on config #12

Merged
merged 2 commits into from
May 12, 2018
Merged

log heartbeat if true on config #12

merged 2 commits into from
May 12, 2018

Conversation

henrod
Copy link
Contributor

@henrod henrod commented May 4, 2018

No description provided.

@coveralls
Copy link

coveralls commented May 5, 2018

Pull Request Test Coverage Report for Build 148

  • 5 of 5 (100.0%) changed or added relevant lines in 2 files are covered.
  • 2 unchanged lines in 1 file lost coverage.
  • Overall coverage increased (+0.3%) to 81.889%

Files with Coverage Reduction New Missed Lines %
agent/agent.go 2 83.74%
Totals Coverage Status
Change from base Build 144: 0.3%
Covered Lines: 3147
Relevant Lines: 3843

💛 - Coveralls

@felipejfc
Copy link
Contributor

you are missing a default value, I recommend setting default true in config.go

@henrod
Copy link
Contributor Author

henrod commented May 5, 2018

Actually I thought that would be better if the default value was false (that's why I didn't put on config.go). If the heartbeat fails, an error would be logged and we would know.

But I can make the default true, if you prefer.

@felipejfc
Copy link
Contributor

I do, this is useful information and that's what debug log is for...

@felipejfc felipejfc merged commit c30d3af into master May 12, 2018
@henrod henrod deleted the feature/heartbeat_log branch July 18, 2018 16:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants