Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor Agent #127

Merged
merged 1 commit into from May 4, 2020
Merged

Refactor Agent #127

merged 1 commit into from May 4, 2020

Conversation

felipejfc
Copy link
Contributor

With this pr we send writes from only 1 goroutine (fixes #112), also, make the logic more readable.

@felipejfc
Copy link
Contributor Author

@cscatolini I'd like your review since you were the one who implemented jaeger and I made some changes to reporting hoping not to change the logic :)

@coveralls
Copy link

Pull Request Test Coverage Report for Build 1032

  • 52 of 70 (74.29%) changed or added relevant lines in 3 files are covered.
  • 8 unchanged lines in 2 files lost coverage.
  • Overall coverage increased (+0.2%) to 69.122%

Changes Missing Coverage Covered Lines Changed/Added Lines %
metrics/report.go 1 3 33.33%
service/handler.go 2 5 40.0%
agent/agent.go 49 62 79.03%
Files with Coverage Reduction New Missed Lines %
agent/agent.go 4 85.47%
cluster/etcd_service_discovery.go 4 81.34%
Totals Coverage Status
Change from base Build 1029: 0.2%
Covered Lines: 4580
Relevant Lines: 6626

💛 - Coveralls

@felipejfc felipejfc merged commit eee2f1c into master May 4, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

concurrent write to websocket connection
2 participants