using dieChan to close application #17
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pull Request Test Coverage Report for Build 196
💛 - Coveralls |
cscatolini
approved these changes
Jun 4, 2018
There was a problem hiding this comment.
LGTM
@henrod apparently you need to fix some conflicts before I can merge this using the UI.
henrod
force-pushed
the
feature/nats_die_chan
branch
from
d152b83
to
5621f67
Compare
henrod
force-pushed
the
feature/nats_die_chan
branch
from
5621f67
to
77a68f4
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change the way nats module closes the application when it can't reconnect anymore.
Also, made a test on
cluster/nats_rpc_common_test.goto make sure the appDieChan is being closed when can't reconnect after 1 retry.