Change initial size of get servers return map #230
Merged
+1
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pull Request Test Coverage Report for Build 1105367087
💛 - Coveralls |
henriqueoelze
approved these changes
Aug 6, 2021
|
Not really, since this isn't a bug fix, only a change on the code to make it more readable. We could have a map with an initial size less than necessary, but since it is the initial size, there is no problem with adding more elements. (here is a short example: https://play.golang.org/p/RxcuCNQ5lNG) |
gabrielcorado
deleted the
feature/change-initial-size-get-servers-return-map
branch
edisonwsk
pushed a commit
to edisonwsk/pitaya
that referenced
this pull request
Aug 20, 2021
…initial-size-get-servers-return-map Change initial size of get servers return map
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #229
The initial size of the map used to return the servers (on ETCD service discovery) was using an incorrect reference. Even though this mistake didn't cause any issue, changing it makes it less confusing while reading the code.