Fix concurrency bottleneck, improve shutdown draining #278
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rsafonseca
force-pushed
the
fix_concurrency_bottleneck
branch
from
34178cf
to
9a61c9f
Compare
Pull Request Test Coverage Report for Build 2658393544
💛 - Coveralls |
felipejfc
requested changes
Jul 12, 2022
| go ns.handleMessages() | ||
|
|
||
| go func() { | ||
| <-ns.stopChan |
There was a problem hiding this comment.
Can we move all this logic to a method of it's own? Or inside stop/shutdown methods of this class.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes a bottleneck to concurrent processing caused by the handleMessages() function by offloading most of the processing handled by this function to the processMessage() workers, and avoiding an additional data copy to another channel.