Make prometheus monitoring optional #29
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pull Request Test Coverage Report for Build 293
💛 - Coveralls |
felipejfc
reviewed
Jul 19, 2018
config/config.go
Outdated
| @@ -89,6 +89,7 @@ func (c *Config) fillDefaultValues() { | |||
| "pitaya.metrics.statsd.rate": 1, | |||
| "pitaya.metrics.prometheus.port": 9090, | |||
| "pitaya.metrics.tags": map[string]string{}, | |||
| "pitaya.metrics.prometheus.enabled": true, | |||
There was a problem hiding this comment.
I'm thinking of changing this default value to false and logging that monitoring is disabled... this would make development easier IMO
There was a problem hiding this comment.
I left it enabled by default to avoid breaking existing applications, but I agree that leaving it disabled by default would avoid some pain when running locally
There was a problem hiding this comment.
we just need to ensure to add the env var to turn it on on the current production applications and then it will be safe to turn it off by default :)
There was a problem hiding this comment.
Disabled it by default now
cscatolini
approved these changes
Jul 19, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.