Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix some connector rpc messaging issues, avoid ETCD log noise when using etcd-proxy #295

Merged
merged 9 commits into from
Feb 10, 2023
Merged

Fix some connector rpc messaging issues, avoid ETCD log noise when using etcd-proxy #295

merged 9 commits into from
Feb 10, 2023

Conversation

rsafonseca
Copy link
Contributor

No description provided.

@coveralls
Copy link

coveralls commented Jan 19, 2023 •
edited
Loading

Pull Request Test Coverage Report for Build 3999022334

  • 61 of 131 (46.56%) changed or added relevant lines in 11 files are covered.
  • 1 unchanged line in 1 file lost coverage.
  • Overall coverage decreased (-0.2%) to 62.053%
Changes Missing Coverage Covered Lines Changed/Added Lines %
acceptor/ws_acceptor.go 0 2 0.0%
app.go 4 6 66.67%
cluster/etcd_service_discovery.go 0 2 0.0%
cluster/nats_rpc_server.go 0 4 0.0%
acceptor/tcp_acceptor.go 14 30 46.67%
session/session.go 17 38 44.74%
service/remote.go 0 23 0.0%
Files with Coverage Reduction New Missed Lines %
acceptor/tcp_acceptor.go 1 73.45%
Totals Coverage Status
Change from base Build 2863670078: -0.2%
Covered Lines: 4716
Relevant Lines: 7600
💛 - Coveralls

felipejfc
felipejfc requested changes Jan 23, 2023
View reviewed changes
Copy link
Contributor

@felipejfc felipejfc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left some comments. Next time try to split into multiple PRs instead of a single with multiple changes :)

acceptor/acceptor.go Show resolved Hide resolved
cluster/etcd_service_discovery.go Show resolved Hide resolved
service/remote.go Show resolved Hide resolved
service/remote.go Outdated Show resolved Hide resolved
session/session.go Outdated Show resolved Hide resolved
cluster/nats_rpc_client.go Outdated Show resolved Hide resolved
cluster/nats_rpc_client.go Outdated Show resolved Hide resolved
@rsafonseca rsafonseca merged commit 8c6c7bc into main Feb 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@felipejfc felipejfc felipejfc requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@rsafonseca @coveralls @felipejfc