Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #317, Prevents premature closure of the channel in case of a timeo… #324

Closed
wants to merge 4 commits into from

Conversation

haoyu234
Copy link
Contributor

…ut that leads to a crash

  1. Adjusting the timing of channel closures
  2. Ensure that the channel is of sufficient size

…ut that leads to a crash

1. Adjusting the timing of channel closures
2. Ensure that the channel is of sufficient size
@haoyu234 haoyu234 changed the title Fix 317, Prevents premature closure of the channel in case of a timeo… Fix #317, Prevents premature closure of the channel in case of a timeo… Jul 28, 2023
@coveralls
Copy link

coveralls commented Jul 31, 2023

Pull Request Test Coverage Report for Build 5710379413

  • 0 of 2 (0.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 62.238%

Changes Missing Coverage Covered Lines Changed/Added Lines %
cluster/etcd_service_discovery.go 0 2 0.0%
Totals Coverage Status
Change from base Build 5658434483: 0.0%
Covered Lines: 4783
Relevant Lines: 7685

💛 - Coveralls

…ut that leads to a crash

1. Adjusting the timing of channel closures
2. Ensure that the channel is of sufficient size
@haoyu234 haoyu234 closed this by deleting the head repository Jul 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants