Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #317, Prevents premature closure of the channel in case of a timeout that leads to a panic #326

Merged
merged 1 commit into from
Sep 6, 2023

Conversation

haoyu234
Copy link
Contributor

  1. Adjusting the timing of channel closures
  2. Ensure that the channel is of sufficient size

sorry, the previous pr accidentally added other extraneous information, so I recreated a new pr.

…out that leads to a panic

1. Adjusting the timing of channel closures
2. Ensure that the channel is of sufficient size
@coveralls
Copy link

Pull Request Test Coverage Report for Build 5710510990

  • 0 of 2 (0.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 62.238%

Changes Missing Coverage Covered Lines Changed/Added Lines %
cluster/etcd_service_discovery.go 0 2 0.0%
Totals Coverage Status
Change from base Build 5658434483: 0.0%
Covered Lines: 4783
Relevant Lines: 7685

💛 - Coveralls

@felipejfc felipejfc merged commit de646f2 into topfreegames:main Sep 6, 2023
4 checks passed
@haoyu234 haoyu234 deleted the patch-1 branch September 6, 2023 14:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants