Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix #328, TestAgentHandle fails randomly #329

Merged
merged 2 commits into from
Sep 6, 2023
Merged

Fix #328, TestAgentHandle fails randomly #329

merged 2 commits into from
Sep 6, 2023

Conversation

haoyu234
Copy link
Contributor

@haoyu234 haoyu234 commented Jul 31, 2023 •
edited
Loading

I suspect go ag.Handle() executes so early that some EXPECT() calls are missed (line 1022), maybe we should put it after all EXPECT() calls.

@coveralls
Copy link

Pull Request Test Coverage Report for Build 5829953166

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 62.238%
Totals Coverage Status
Change from base Build 5658434483: 0.0%
Covered Lines: 4783
Relevant Lines: 7685
💛 - Coveralls

@felipejfc felipejfc merged commit 56d8579 into topfreegames:main Sep 6, 2023
4 checks passed
@haoyu234 haoyu234 deleted the patch-3 branch September 6, 2023 14:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@felipejfc felipejfc felipejfc approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@haoyu234 @coveralls @felipejfc