Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed an issue where variables were printed with the wrong placeholder #335

Merged
merged 1 commit into from
Aug 25, 2023
Merged

Fixed an issue where variables were printed with the wrong placeholder #335

merged 1 commit into from
Aug 25, 2023

Conversation

haoyu234
Copy link
Contributor

Here are some sample outputs:

before

DEBU[0000] adding server &{f8da4226-e555-d75f-bf35-e7e3f9e84945 chat map[] %!s(bool=true) h.dev}  source=pitaya
DEBU[0000] subs channel size: %!d(float64=0), max: %!d(float64=0), dropped: 0  source=tank

after

DEBU[0000] adding server &{5589a691-ad56-4d31-bca2-55d742d97ece connector map[] true h.dev}  source=pitaya
DEBU[0000] subs channel size: 0, max: 0, dropped: 0      source=pitaya

@coveralls
Copy link

coveralls commented Aug 11, 2023

Pull Request Test Coverage Report for Build 5830029887

  • 1 of 2 (50.0%) changed or added relevant lines in 2 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 62.238%

Changes Missing Coverage Covered Lines Changed/Added Lines %
cluster/etcd_service_discovery.go 0 1 0.0%
Totals Coverage Status
Change from base Build 5658434483: 0.0%
Covered Lines: 4783
Relevant Lines: 7685

💛 - Coveralls

@felipejfc felipejfc merged commit fe4ef7d into topfreegames:main Aug 25, 2023
4 checks passed
@felipejfc
Copy link
Contributor

thanks for the contribution

@haoyu234 haoyu234 deleted the fixplaceholder branch August 26, 2023 00:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants