Fix agent socket cleanup #343
Conversation
…acceptors and ensure they are listening before moving forward with app initialization
Pull Request Test Coverage Report for Build 6172031201
💛 - Coveralls |
| @@ -160,6 +170,7 @@ func (w *WSAcceptor) serve(upgrader *websocket.Upgrader) { | |||
|
|
|||
| // Stop stops the acceptor | |||
| func (w *WSAcceptor) Stop() { | |||
| w.running = false | |||
There was a problem hiding this comment.
only if the below lines didn't error
There was a problem hiding this comment.
once you issue the Stop() it should be marked as not running anyway, since there might be an error where it couldn't run close() because it was already closed or other issue, and in that situation, the acceptor would keep getting marked as running, when it really wasn't (if it can't even close itself, it should not have running=true). This matches the existing implementation on the TCPAcceptor
app.go
Outdated
| for a.IsRunning() == false { | ||
| logger.Log.Infof("Waiting for TCP acceptor %s to start on addr %s", reflect.TypeOf(a), a.GetConfiguredAddress()) | ||
| } | ||
|
|
||
| logger.Log.Infof("listening with acceptor %s on addr %s", reflect.TypeOf(a), a.GetAddr()) |
There was a problem hiding this comment.
Should we also change this line to print configured address?
There was a problem hiding this comment.
Not sure i follow, it already does
There was a problem hiding this comment.
If you're talking about the line that i didn't touch, it's better to keep it as it is. The configured address with print for example 0.0.0.0:0 (while the socket isn't up) and the other one will print the actual port that was used for the socket. This is useful in case for example if you don't specify a port (like on tests for example, but potentially in real life too). It will also print the IP that it was bound to on the local network stack.
There was a problem hiding this comment.
I'm pretty sure this log line is broken though, it's not properly printing the port
Fixes #289
Resolves several test flakes
Ensures Acceptors are listening before moving forward with initialization