Refactor/etcd bootstrap #36
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
golangci
reviewed
Aug 8, 2018
| @@ -104,7 +105,7 @@ func TestEtcdSDBootstrapServer(t *testing.T) { | |||
| c, cli := helpers.GetTestEtcd(t) | |||
| defer c.Terminate(t) | |||
| e := getEtcdSD(t, config, table.server, cli) | |||
| e.bootstrapLease() | |||
| e.grantLease() | |||
There was a problem hiding this comment.
Error return value of e.grantLease is not checked
| @@ -129,7 +130,7 @@ func TestEtcdSDDeleteServer(t *testing.T) { | |||
| c, cli := helpers.GetTestEtcd(t) | |||
| defer c.Terminate(t) | |||
| e := getEtcdSD(t, config, table.server, cli) | |||
| e.bootstrapLease() | |||
| e.grantLease() | |||
There was a problem hiding this comment.
Error return value of e.grantLease is not checked
| @@ -189,7 +190,7 @@ func TestEtcdSDGetServer(t *testing.T) { | |||
| c, cli := helpers.GetTestEtcd(t) | |||
| defer c.Terminate(t) | |||
| e := getEtcdSD(t, config, table.server, cli) | |||
| e.bootstrapLease() | |||
| e.grantLease() | |||
There was a problem hiding this comment.
Error return value of e.grantLease is not checked
| syncServersInterval time.Duration | ||
| heartbeatTTL time.Duration | ||
| logHeartbeat bool | ||
| lastHeartbeatTime time.Time |
Pull Request Test Coverage Report for Build 353
💛 - Coveralls |
gabrielerzinger
force-pushed
the
refactor/etcd-Bootstrap
branch
from
72e6c86
to
6f5f8b3
Compare
golangci
reviewed
Aug 9, 2018
| @@ -130,7 +130,7 @@ func TestEtcdSDDeleteServer(t *testing.T) { | |||
| c, cli := helpers.GetTestEtcd(t) | |||
| defer c.Terminate(t) | |||
| e := getEtcdSD(t, config, table.server, cli) | |||
| e.bootstrapLease() | |||
| e.grantLease() | |||
There was a problem hiding this comment.
Error return value of e.grantLease is not checked
| @@ -190,7 +190,7 @@ func TestEtcdSDGetServer(t *testing.T) { | |||
| c, cli := helpers.GetTestEtcd(t) | |||
| defer c.Terminate(t) | |||
| e := getEtcdSD(t, config, table.server, cli) | |||
| e.bootstrapLease() | |||
| e.grantLease() | |||
There was a problem hiding this comment.
Error return value of e.grantLease is not checked
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refactored the code to made it more clear when etcd was really starting or just trying to reconnect in order to attend to @andrehp suggestions in issue #34 .