Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Proxy proto tls fix #387

Merged
merged 2 commits into from
Feb 22, 2024
Merged

Proxy proto tls fix #387

merged 2 commits into from
Feb 22, 2024

Conversation

rsafonseca
Copy link
Contributor

@rsafonseca rsafonseca commented Feb 22, 2024

Fixes proxy protocol implementation to work over TLS TCP Acceptors.

@coveralls
Copy link

Pull Request Test Coverage Report for Build 8006935425

Details

  • -30 of 66 (54.55%) changed or added relevant lines in 3 files are covered.
  • 2 unchanged lines in 1 file lost coverage.
  • Overall coverage decreased (-0.02%) to 62.074%

Changes Missing Coverage Covered Lines Changed/Added Lines %
app.go 1 2 50.0%
acceptor/tcp_acceptor.go 23 26 88.46%
acceptor/proxyprotowrapper.go 12 38 31.58%
Files with Coverage Reduction New Missed Lines %
modules/binary.go 2 78.26%
Totals Coverage Status
Change from base Build 7991220445: -0.02%
Covered Lines: 4825
Relevant Lines: 7773

💛 - Coveralls

@rsafonseca rsafonseca merged commit 7a573b7 into main Feb 22, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants