Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat/customize rpc timeout #393

Merged
merged 2 commits into from
Apr 25, 2024

Conversation

bruce1125
Copy link
Contributor

update docs to explain how to customize the timeout value

@coveralls
Copy link

Pull Request Test Coverage Report for Build 8812929899

Details

  • 10 of 10 (100.0%) changed or added relevant lines in 1 file are covered.
  • 11 unchanged lines in 2 files lost coverage.
  • Overall coverage increased (+0.04%) to 62.129%

Files with Coverage Reduction New Missed Lines %
groups/memory_group_service.go 1 84.25%
cluster/nats_rpc_client.go 10 84.81%
Totals Coverage Status
Change from base Build 8807700949: 0.04%
Covered Lines: 4833
Relevant Lines: 7779

💛 - Coveralls

Copy link
Contributor

@felipejfc felipejfc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.
We should create a helper later like, a new method in the interface like:
RPC(msg, route, ..., timeout) which sets this value on the context, so that this feature would be easier accessible and we avoid unmarshal errors on the timeout value

@felipejfc felipejfc merged commit 5b39b76 into topfreegames:main Apr 25, 2024
4 checks passed
@felipejfc
Copy link
Contributor

FYI new version released with this change: https://github.com/topfreegames/pitaya/releases/tag/v2.11.0

@bruce1125
Copy link
Contributor Author

LGTM. We should create a helper later like, a new method in the interface like: RPC(msg, route, ..., timeout) which sets this value on the context, so that this feature would be easier accessible and we avoid unmarshal errors on the timeout value

That's a good idear, waiting for the new API.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants