Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Correct user kick channel type #45

Merged
merged 1 commit into from Aug 20, 2018
Merged

Correct user kick channel type #45

merged 1 commit into from Aug 20, 2018

Conversation

gabrielerzinger
Copy link
Contributor

As stated by @cscatolini at #43, the user kick channel should be type protos.KickMsg instead of nats.Msg and processKick should use the same logic that processPushes

@coveralls
Copy link

Pull Request Test Coverage Report for Build 455

  • 9 of 11 (81.82%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 75.548%
Changes Missing Coverage Covered Lines Changed/Added Lines %
cluster/nats_rpc_server.go 9 11 81.82%
Totals Coverage Status
Change from base Build 451: 0.0%
Covered Lines: 3791
Relevant Lines: 5018
💛 - Coveralls

cscatolini
cscatolini approved these changes Aug 20, 2018
View reviewed changes
Copy link
Contributor

@cscatolini cscatolini left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great! 🚀

@cscatolini cscatolini merged commit a38f381 into master Aug 20, 2018
@cscatolini cscatolini deleted the refactor/kickch branch September 12, 2018 16:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cscatolini cscatolini cscatolini approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@gabrielerzinger @coveralls @cscatolini