Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixing nats subscription leak #48

Merged
merged 1 commit into from
Aug 24, 2018
Merged

Fixing nats subscription leak #48

merged 1 commit into from
Aug 24, 2018

Conversation

andrehp
Copy link
Contributor

@andrehp andrehp commented Aug 24, 2018

Fixing subscription and goroutine leak when closing sessions

@andrehp andrehp requested a review from rcmgleite August 24, 2018 18:26
@coveralls
Copy link

Pull Request Test Coverage Report for Build 473

  • 15 of 16 (93.75%) changed or added relevant lines in 2 files are covered.
  • 2 unchanged lines in 1 file lost coverage.
  • Overall coverage decreased (-0.03%) to 74.985%
Changes Missing Coverage Covered Lines Changed/Added Lines %
session/session.go 7 8 87.5%
Files with Coverage Reduction New Missed Lines %
acceptor/tcp_acceptor.go 2 85.48%
Totals Coverage Status
Change from base Build 471: -0.03%
Covered Lines: 3792
Relevant Lines: 5057
💛 - Coveralls

rcmgleite
rcmgleite approved these changes Aug 24, 2018
View reviewed changes
Copy link
Contributor

@rcmgleite rcmgleite left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@andrehp andrehp merged commit 8505d44 into master Aug 24, 2018
@andrehp andrehp deleted the fix/natsSubLeak branch August 24, 2018 18:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rcmgleite rcmgleite rcmgleite approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@andrehp @coveralls @rcmgleite