New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
report sys metrics #53
Conversation
dacf93b
to
b3ce8cf
Compare
m := &runtime.MemStats{} | ||
runtime.ReadMemStats(m) | ||
|
||
r.ReportGauge(Goroutines, map[string]string{}, float64(num)) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Error return value of r.ReportGauge
is not checked
runtime.ReadMemStats(m) | ||
|
||
r.ReportGauge(Goroutines, map[string]string{}, float64(num)) | ||
r.ReportGauge(HeapSize, map[string]string{}, float64(m.Alloc)) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Error return value of r.ReportGauge
is not checked
|
||
r.ReportGauge(Goroutines, map[string]string{}, float64(num)) | ||
r.ReportGauge(HeapSize, map[string]string{}, float64(m.Alloc)) | ||
r.ReportGauge(HeapObjects, map[string]string{}, float64(m.HeapObjects)) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Error return value of r.ReportGauge
is not checked
Pull Request Test Coverage Report for Build 493
💛 - Coveralls |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please update the docs
I updated on last commit @andrehp |
LGTM, let's just wait and see if @cscatolini has anything to say about this PR |
LGTM |
No description provided.