Additional Tags and routingFunc #55
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
henrod
force-pushed
the
feature/ctx-routing-func
branch
from
cb1f98e
to
e5d355a
Compare
Pull Request Test Coverage Report for Build 507
💛 - Coveralls |
andrehp
approved these changes
Sep 12, 2018
metrics/prometheus_reporter.go
Outdated
| g.With(labels).Set(value) | ||
| return nil | ||
| } | ||
| return constants.ErrMetricNotKnown | ||
| } | ||
|
|
||
| // ensureLabels check if labels contains the additionalLabels values, |
|
Good job |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
pitaya.metrics.tagstopitaya.metrics.constTagssince these tags are indeed constantspitaya.metrics.additionalTagswhich is a map from tag to default value. The values can be added using the methodAddMetricTagsToPropagateCtx