Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add hostname to server type #62

Merged
merged 1 commit into from
Oct 3, 2018
Merged

Add hostname to server type #62

merged 1 commit into from
Oct 3, 2018

Conversation

gabrielerzinger
Copy link
Contributor

I think it would be useful to have the server hostname information

@coveralls
Copy link

Pull Request Test Coverage Report for Build 584

  • 3 of 5 (60.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.2%) to 75.009%
Changes Missing Coverage Covered Lines Changed/Added Lines %
cluster/server.go 3 5 60.0%
Totals Coverage Status
Change from base Build 540: 0.2%
Covered Lines: 3959
Relevant Lines: 5278
💛 - Coveralls

cscatolini
cscatolini approved these changes Oct 3, 2018
View reviewed changes
Copy link
Contributor

@cscatolini cscatolini left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job

@cscatolini cscatolini merged commit 08d1d52 into master Oct 3, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cscatolini cscatolini cscatolini approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@gabrielerzinger @coveralls @cscatolini