-
Notifications
You must be signed in to change notification settings - Fork 458
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/custom metrics #67
Conversation
Pull Request Test Coverage Report for Build 635
💛 - Coveralls |
Could you describe a little better how to use the custom metrics? The configuration values are not very clear for me |
I don't know if doc is the better choice for this, maybe add an example? |
Yeah, I guess an example would already help |
@andrehp I made an example |
Nice, could you just add a small paragraph to the docs mentioning custom metrics? https://github.com/topfreegames/pitaya/blob/master/docs/features.md#monitoring |
@andrehp do you think this is enough? |
Yeah, LGTM I'm gonna merge this, good job! |
Possibility to add custom metrics on starting application. The danger in this is that a wrong config will cause the app to crash because the prometheus lib crashes.