Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/custom metrics #67

Merged
merged 4 commits into from
Nov 6, 2018
Merged

Feature/custom metrics #67

merged 4 commits into from
Nov 6, 2018

Conversation

henrod
Copy link
Contributor

@henrod henrod commented Nov 5, 2018

Possibility to add custom metrics on starting application. The danger in this is that a wrong config will cause the app to crash because the prometheus lib crashes.

@henrod henrod requested a review from andrehp November 5, 2018 12:38
@coveralls
Copy link

coveralls commented Nov 5, 2018

Pull Request Test Coverage Report for Build 635

  • 9 of 75 (12.0%) changed or added relevant lines in 4 files are covered.
  • 5 unchanged lines in 2 files lost coverage.
  • Overall coverage decreased (-0.9%) to 72.735%

Changes Missing Coverage Covered Lines Changed/Added Lines %
app.go 8 9 88.89%
config/config.go 1 4 25.0%
metrics/models.go 0 8 0.0%
metrics/prometheus_reporter.go 0 54 0.0%
Files with Coverage Reduction New Missed Lines %
agent/agent.go 2 81.79%
cluster/etcd_service_discovery.go 3 78.14%
Totals Coverage Status
Change from base Build 623: -0.9%
Covered Lines: 4055
Relevant Lines: 5575

💛 - Coveralls

@andrehp
Copy link
Contributor

andrehp commented Nov 5, 2018

Could you describe a little better how to use the custom metrics? The configuration values are not very clear for me

@henrod
Copy link
Contributor Author

henrod commented Nov 5, 2018

I don't know if doc is the better choice for this, maybe add an example?

@andrehp
Copy link
Contributor

andrehp commented Nov 5, 2018

Yeah, I guess an example would already help

@henrod
Copy link
Contributor Author

henrod commented Nov 5, 2018

@andrehp I made an example

@andrehp
Copy link
Contributor

andrehp commented Nov 6, 2018

Nice, could you just add a small paragraph to the docs mentioning custom metrics?

https://github.com/topfreegames/pitaya/blob/master/docs/features.md#monitoring

@henrod
Copy link
Contributor Author

henrod commented Nov 6, 2018

@andrehp do you think this is enough?

@andrehp
Copy link
Contributor

andrehp commented Nov 6, 2018

Yeah, LGTM

I'm gonna merge this, good job!

@andrehp andrehp merged commit 050a0e8 into master Nov 6, 2018
@henrod henrod deleted the feature/custom-metrics branch December 26, 2018 13:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants