Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Changing tracing to work with elasticapm #77

Merged
merged 2 commits into from Jan 12, 2019
Merged

Changing tracing to work with elasticapm #77

merged 2 commits into from Jan 12, 2019

Conversation

andrehp
Copy link
Contributor

@andrehp andrehp commented Jan 8, 2019

No description provided.

@coveralls
Copy link

coveralls commented Jan 8, 2019 •
edited

Pull Request Test Coverage Report for Build 734

  • 13 of 21 (61.9%) changed or added relevant lines in 1 file are covered.
  • 4 unchanged lines in 2 files lost coverage.
  • Overall coverage increased (+0.01%) to 69.002%
Changes Missing Coverage Covered Lines Changed/Added Lines %
tracing/span.go 13 21 61.9%
Files with Coverage Reduction New Missed Lines %
tracing/span.go 2 79.1%
agent/agent.go 2 81.79%
Totals Coverage Status
Change from base Build 730: 0.01%
Covered Lines: 4274
Relevant Lines: 6194
💛 - Coveralls

cscatolini
cscatolini approved these changes Jan 11, 2019
View reviewed changes
Copy link
Contributor

@cscatolini cscatolini left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Just a small question about ignored keys.

tracing/span.go Show resolved Hide resolved
@andrehp andrehp merged commit 880566d into master Jan 12, 2019
@andrehp andrehp deleted the feature/elasticapm branch January 12, 2019 01:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cscatolini cscatolini cscatolini approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@andrehp @coveralls @cscatolini