Added mutex to agent close to avoid panic #86

andrehp · 2019-02-12T19:50:41Z

The panic was caused by trying to close the channel multiple times,
this was fixed by adding a mutex to the close operation.

Fixes #85

coveralls · 2019-02-12T22:29:10Z

Pull Request Test Coverage Report for Build 754

3 of 3 (100.0%) changed or added relevant lines in 1 file are covered.
2 unchanged lines in 1 file lost coverage.
Overall coverage decreased (-0.02%) to 68.846%

Files with Coverage Reduction	New Missed Lines	%
modules/binary.go	2	73.91%

Totals
Change from base Build 750:	-0.02%
Covered Lines:	4285
Relevant Lines:	6224

💛 - Coveralls

The panic was caused by trying to close the channel multiple times, this was fixed by adding a mutex to the close operation.

andrehp force-pushed the fix/agent-close-panic branch from 76ac8c4 to 1f578d9 Compare February 15, 2019 23:31

Added mutex to agent close to avoid panic

3e4bc9d

The panic was caused by trying to close the channel multiple times, this was fixed by adding a mutex to the close operation.

andrehp force-pushed the fix/agent-close-panic branch from 1f578d9 to 3e4bc9d Compare February 20, 2019 14:25

andrehp merged commit 252ecec into master Feb 20, 2019

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Added mutex to agent close to avoid panic #86

Added mutex to agent close to avoid panic #86

andrehp commented Feb 12, 2019 •

edited

coveralls commented Feb 12, 2019 •

edited

Added mutex to agent close to avoid panic #86

Added mutex to agent close to avoid panic #86

Conversation

andrehp commented Feb 12, 2019 • edited

coveralls commented Feb 12, 2019 • edited

Pull Request Test Coverage Report for Build 754

💛 - Coveralls

andrehp commented Feb 12, 2019 •

edited

coveralls commented Feb 12, 2019 •

edited