Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix report rpc error #91

Merged
merged 1 commit into from Feb 21, 2019
Merged

fix report rpc error #91

merged 1 commit into from Feb 21, 2019

Conversation

henrod
Copy link
Contributor

@henrod henrod commented Feb 21, 2019

When rpc returns an error, it was not reported since the returned error was not used on report

@henrod henrod requested a review from andrehp February 21, 2019 22:12
@andrehp andrehp merged commit 8cbf617 into master Feb 21, 2019
@coveralls
Copy link

Pull Request Test Coverage Report for Build 762

  • 2 of 4 (50.0%) changed or added relevant lines in 2 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.03%) to 68.879%
Changes Missing Coverage Covered Lines Changed/Added Lines %
cluster/grpc_rpc_client.go 0 2 0.0%
Totals Coverage Status
Change from base Build 755: 0.03%
Covered Lines: 4287
Relevant Lines: 6224
💛 - Coveralls

@henrod henrod deleted the feature/fix-report-rpc-error branch April 9, 2019 17:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andrehp andrehp andrehp approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@henrod @coveralls @andrehp