-
Notifications
You must be signed in to change notification settings - Fork 22
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
* Add cache for enrich metadata * Change key format * Remove default annotation * Refactor to decouple configs using options * Fix tests * Refactor to use decorator for the cache * Rename struct * Duplicated code * Change empty config check * Enable cloud save and enrich if config provided * Remove unnecessary if
- Loading branch information
1 parent
cda5bf0
commit a47754d
Showing
19 changed files
with
922 additions
and
184 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,94 @@ | ||
| package cache | ||
|
|
||
| import ( | ||
| "context" | ||
| "encoding/json" | ||
| "fmt" | ||
| "github.com/go-redis/redis/v8" | ||
| "github.com/topfreegames/podium/leaderboard/v2/enriching" | ||
| "github.com/topfreegames/podium/leaderboard/v2/model" | ||
| "time" | ||
| ) | ||
|
|
||
| // cacheKeyFormat is {tenantID}:{leaderboardID}:{memberID} | ||
| const cacheKeyFormat = "leaderboards-enrich-caching:%s:%s:%s" | ||
|
|
||
| type enricherRedisCache struct { | ||
| redis *redis.Client | ||
| } | ||
|
|
||
| var _ enriching.EnricherCache = &enricherRedisCache{} | ||
|
|
||
| func NewEnricherRedisCache( | ||
| redis *redis.Client, | ||
| ) enriching.EnricherCache { | ||
| return &enricherRedisCache{ | ||
| redis: redis, | ||
| } | ||
| } | ||
|
|
||
| func (e *enricherRedisCache) Get( | ||
| ctx context.Context, | ||
| tenantID, | ||
| leaderboardID string, | ||
| members []*model.Member, | ||
| ) (map[string]map[string]string, bool, error) { | ||
| keys := getKeysFromMemberArray(tenantID, leaderboardID, members) | ||
| dataArray, err := e.redis.MGet(ctx, keys...).Result() | ||
| if err != nil { | ||
| return nil, false, fmt.Errorf("failed to get data from cacheConfig: %w", err) | ||
| } | ||
|
|
||
| dataMap := make(map[string]map[string]string) | ||
| for i, data := range dataArray { | ||
| if data == nil { | ||
| return nil, false, nil | ||
| } | ||
|
|
||
| unmarshaled := map[string]string{} | ||
| err := json.Unmarshal([]byte(data.(string)), &unmarshaled) | ||
| if err != nil { | ||
| return nil, false, fmt.Errorf("failed to unmarshal data: %w", err) | ||
| } | ||
|
|
||
| memberID := members[i].PublicID | ||
| dataMap[memberID] = unmarshaled | ||
| } | ||
|
|
||
| return dataMap, true, nil | ||
| } | ||
|
|
||
| func (e *enricherRedisCache) Set( | ||
| ctx context.Context, | ||
| tenantID, | ||
| leaderboardID string, | ||
| members []*model.Member, | ||
| ttl time.Duration, | ||
| ) error { | ||
| keys := getKeysFromMemberArray(tenantID, leaderboardID, members) | ||
| pipe := e.redis.TxPipeline() | ||
| for i, member := range members { | ||
| if member.Metadata != nil { | ||
| marshaled, err := json.Marshal(member.Metadata) | ||
| if err != nil { | ||
| return fmt.Errorf("failed to marshal metadata: %w", err) | ||
| } | ||
| pipe.Set(ctx, keys[i], marshaled, ttl) | ||
| } | ||
| } | ||
|
|
||
| _, err := pipe.Exec(ctx) | ||
| if err != nil { | ||
| return fmt.Errorf("failed to set members in cacheConfig: %w", err) | ||
| } | ||
|
|
||
| return nil | ||
| } | ||
|
|
||
| func getKeysFromMemberArray(tenantID, leaderboardID string, members []*model.Member) []string { | ||
| keys := make([]string, len(members)) | ||
| for i, member := range members { | ||
| keys[i] = fmt.Sprintf(cacheKeyFormat, tenantID, leaderboardID, member.PublicID) | ||
| } | ||
| return keys | ||
| } |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,12 @@ | ||
| package cache | ||
|
|
||
| import ( | ||
| . "github.com/onsi/ginkgo" | ||
| . "github.com/onsi/gomega" | ||
| "testing" | ||
| ) | ||
|
|
||
| func TestEnrichingCache(t *testing.T) { | ||
| RegisterFailHandler(Fail) | ||
| RunSpecs(t, "Enriching Cache Suite") | ||
| } |
Oops, something went wrong.