[DONE] Feature/lib members around member #16
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rcmgleite
force-pushed
the
feature/lib-members-around-member
branch
from
2f6bc19
to
c6b7114
Compare
henrod
reviewed
Jul 30, 2018
lib/lib.go
Outdated
| @@ -100,7 +100,7 @@ func getHTTPClient(timeoutMs int) *http.Client { | |||
| func NewPodium(config *viper.Viper) PodiumInterface { | |||
| config.SetDefault("podium.timeout", 1000) | |||
There was a problem hiding this comment.
It should be 1 * time.Second here
lib/lib_test.go
Outdated
| @@ -26,6 +26,7 @@ var _ = Describe("Lib", func() { | |||
| config.Set("podium.url", "http://podium") | |||
| config.Set("podium.user", "user") | |||
| config.Set("podium.pass", "pass") | |||
| config.Set("podium.timeout", "1s") | |||
There was a problem hiding this comment.
With that default, this is not necessary anymore
rcmgleite
force-pushed
the
feature/lib-members-around-member
branch
from
c6b7114
to
915029f
Compare
rcmgleite
force-pushed
the
feature/lib-members-around-member
branch
from
915029f
to
d7fe9e3
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.