added redis config to leaderboard and refactored leaderboard module #20
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cscatolini
approved these changes
Jun 13, 2019
api/healthcheck_test.go
Outdated
| @@ -37,7 +37,7 @@ var _ = Describe("Healthcheck Handler", func() { | |||
|
|
|||
| It("Should fail if redis failing", func() { | |||
| a := GetDefaultTestApp() | |||
| a.RedisClient.Client = GetFaultyRedis() | |||
| a.Leaderboards.RedisClient().Client = GetFaultyRedis() | |||
There was a problem hiding this comment.
Should we expose the inner client and allow it to be changed like this?
There was a problem hiding this comment.
Makes sense that we don't. I'll change the test code to allow for the removal of this method.
cscatolini
approved these changes
Jun 13, 2019
|
Great job! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now clients of the podium library can instantiate a client without managing Redis themselves. Refactoring for this also brought the opportunity to make the API cleaner: we no longer need to create a leaderboard every time an operation is needed. We use a single leaderboard client that gives us all leaderboard functionality and redis management.