added prototool #25
Merged
added prototool #25
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Does it make sense to commit the third-party folder? |
|
@cscatolini the third party folder is necessary because dep doesn't download these proto files into the vendor folder. This makes it easier for the developer to generate new protos by just cloning the repo and running make setup (making the project more self contained). |
|
@lucas-machado okay! I'm not a fan of bloated repos but I see the appeal of cloning it with all its deps, so I'm gonna approve it =) |
cscatolini
approved these changes
Jul 16, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WIP: This PR is to implement some of the remaining TODO items left on the Podium project.